Re: [Libreoffice] What do we want from extensions module?

On Sat, 17 Dec 2011, Michael Stahl wrote:

> On 14/12/11 23:28, Peter Foley wrote:
> > On Wed, 14 Dec 2011, Michael Stahl wrote:
>
> > > result of that is in feature/gbuild_extensions branch; ~6 libraries
> > > already converted.
> >
> > I've actually already converted extensions to gbuild. I'm attaching my 
> > current patch which should be essentially complete, however it probably 
> > won't build on mac. 
>
> hi Peter,
>
> that is really great work!
>
> i have just finished reviewing the whole thing...
> because the huge size of the patch made it difficult to review, i've
> split it up into smaller parts that each convert a library.
> then i've committed each patch and in some cases made some small changes
> (only tested on linux, hope i haven't broken more than i fixed).

Yeah, I realized that I should probly have split the conversion up but 
never got around to actually doing it.

> - there is some modification to gbuild core to build 64bit stuff
>   with MSVC; i have no idea whether that is the right way as i don't
>   know anything about MSVC; this really must be reviewed by somebody
>   who does...

I don't know much about MSVC either but the 64-bit stuff seems to build 
on my windows box. However I haven't tested whether it actually works.

Thanks for the review,

Peter