Re: [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency

Thorsten Behrens <thb -AT- documentfoundation.org>
Fri, 16 Dec 2011 23:27:39 +0100

Michael Meeks wrote:

      Are we even certain that this new fix is correct ? I would really
rather see this bed-down in 3.5 and get some wider testing than see it
in 3.4.5 - can't we just revert the original fix there ?

Yes, sure. I'm sorry for boldly suggesting the original patch for
3.4.5 in the first place - we had shipped that for Novell builds,
and I was not aware of any negative consequences.

As for the zip package module, sure, as many places, that would
benefit from more self-documenting code. Alas, that will have to
wait until a few more Impress bugs are ironed out. :)

Cheers,

-- Thorsten

Attachment: pgp0mUhrl76kW.pgp
Description: PGP signature

Context

[Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Thorsten Behrens
- Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Michael Meeks
  - Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Thorsten Behrens
    - Re: [Libreoffice] [REVIEWED] Fix overly zealous check in Zip package consistency · Michael Meeks
      - Re: [Libreoffice] [REVIEWED][PUSHED:3-4] Fix overly zealous check in Zip package consistency · Petr Mladek
      - [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        
        Re: [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Michael Meeks
        
        Re: [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        
        Re: [Libreoffice] [PUSHED-3-4] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Michael Stahl
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Bjoern Michaelsen
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Tor Lillqvist
        
        Re: [Libreoffice] [REVIEWED-3-4-5][PUSHED-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.