Re: [Libreoffice] [REVIEWED][PUSHED:3-4] Fix overly zealous check in Zip package consistency

Petr Mladek <pmladek -AT- suse.cz>
Wed, 14 Dec 2011 15:38:45 +0100

Michael Meeks píše v St 14. 12. 2011 v 14:10 +0000:

On Wed, 2011-12-14 at 14:42 +0100, Thorsten Behrens wrote:

Michael Meeks wrote:

  I'd be happier to see the nMethod being compared if we had removed the
comment, and/or at least understood whether it is still relevant: are we
using/changing nMethod elsewhere ?


Yep, good point. Tweaked for master. That comment looks false, did
not find any place where that would be used - also, FWICT, it would
not comply with the zip appnote...


      Great; I did the same git grep and it seems it's only fiddle with on
writing so we should get it in :-)


Thanks for review. I have pushed it into libreoffice-3-4 branch. It will
be in 3.4.5-rc1.


Best Regards,
Petr

Context

[Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Thorsten Behrens
- Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Michael Meeks
  - Re: [Libreoffice] [REVIEW-3-4] Fix overly zealous check in Zip package consistency · Thorsten Behrens
    - Re: [Libreoffice] [REVIEWED] Fix overly zealous check in Zip package consistency · Michael Meeks
      - Re: [Libreoffice] [REVIEWED][PUSHED:3-4] Fix overly zealous check in Zip package consistency · Petr Mladek
      - [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        
        Re: [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Michael Meeks
        
        Re: [Libreoffice] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        
        Re: [Libreoffice] [PUSHED-3-4] [REVIEW-3-4] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Thorsten Behrens
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Michael Stahl
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Bjoern Michaelsen
        Re: [Libreoffice] [REVIEW-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Tor Lillqvist
        
        Re: [Libreoffice] [REVIEWED-3-4-5][PUSHED-3-4-5] Reverted - Fix overly zealous check in Zip package consistency · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.