Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Pedro Lino píše v So 03. 12. 2011 v 23:40 +0000:
Hi Lionel

Git commit IDs as identifiers have the huge problem that they are not
comparable (one cannot say which one is "greater") without referring
to the repository. How about we also put the *commit* (not author)
timestamp (in UTC) of the top node (commit), and maybe the branch?

That would help!

Something like:

Build assembled from:
 repo  commit   date               branch
 core: 4f11d0a 2011-11-16 21:57:28 master
 help: adcf6d5 2011-11-05 14:01:21 master
 ...

Or instead of pretty-printing the date, just put it as seconds
since the epoch:

 core: 4f11d0a 1321480648 master
 help: adcf6d5 1320501681 master

That would solve the problem when looking into the log file but not
when looking at the About box.

Picking up your (excellent) idea of using the date and converting to a
linear value: if each repository was given a Birth Date and time since
that date converted to a linear value (age), using the Date function
you could get a 10 digit value able to separate builds with one second
time difference.

E.g. If the Core repository was created at midnight Sept 28th 2010
(TDF's birthday) or in linear time (times 100000 to eliminate the
point) 4044900000, then the 4f11d0a 2011-11-16 21:57:28 master

age would be 41491490. This seems like a nice easy number to compare.
In fact a build using code from one second later would be 41491491.

Hmm, we check out the five repositories one by one. It might take some
time if you have slower network connection. There might be more commits
in the other repositories in the meantime => the question is what time
to use. We might end up with 5 times in the end, e.g.:

41491491-41491527-41491568-41491597-41491613

It is quite complex in the end. Also, it would be hard for developers to
get the corresponding commit from it.


I think that we should first define what we expect from the version
number. Note that we could mention more lines in the about dialog.
They are easy to cut&paste, so they should not cause troubles.


I see the following needs and solutions:


    + easily match about dialog with downloaded tarball

      => we need to use the same string in both

         I would add one more line with a time generated by configure
         to the about dialog. The same time should be used in the
         download tarball name


    + easily match build with git commit

      => keep the git IDs in about dialog


    + human readable string for official builds for normal users:

     => I would add one more line, .e.g. 3.5.0-beta1
        it will be used only in the official builds generated from
        release tarballs or release tags


Does it make sense?


Best Regards,
Petr


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.