Re: [Libreoffice] [PATCH] fdo 42286 in calc solved ?

On Tue, 2011-11-15 at 21:12 +0100, Pierre-André Jacquod wrote:

> My solution: suppress this call...
> I have tested it and it seems to work. I did not managed to find a case 
> where something is broken with the filter..
>
> But it seems me too simple.

Yes it is too simple, isn't it?

The good news is that, you are in the right neighborhood.  The bad news
is that, you've just removed a valid functionality.  I'm afraid I can't
push your change, since the line you wish to remove is there for a
reason.

Also, your use case is a weird one.  Normally Calc users don't want to
filter out the bottom empty rows.  In fact, if you have an empty row it
actually acts as a data range separator, which affects what range is
used for so-called "database" operations; filtering, subtotal, sorting
etc.  That's an intended feature, not a bug, and supporting use cases
like yours will not be easy & require non-trivial code change and
perhaps several configuration options too (since the default behavior
can't possibly please all users).

Having said that, this auto range selection code for database ranges has
grown too complex & probably needs some cleanup.  But I'm afraid
removing that line will not be the way to go.  Sorry.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc