Re: [Libreoffice] [PATCH] fix for fdo#40831 - Writer will crash when searching text with using regular expressions

On 12/11/11 08:27, Tomofumi Yagi wrote:
> Hi All,
>
> This patch will fix fdo#40831 "Writer will crash when searching text with using regular 
> expressions".
> Please review my attached patch.
>
> Bug URL: https://bugs.freedesktop.org/show_bug.cgi?id=40831
>
> I reproduced this bug on LibO 3.4 and 3.5.
> This bug occurs when a row or column containing cursor position was removed by substitution. 
> This patch is to skip the process of returning the position of the cursor,
> when the row or column containing cursor position is removed.

hi Tomofumi,

now i remember: this bug is exactly the one i fixed in OOo in CWS
sw34bf04 (issue i102333).

the fix is not merged in libreoffice-3-4, but is in master
(230fcf4a456636bb466f72834cd57238621d206d),
but LO master still crashes while an Apache OOo 3.4 build does not crash...

i will investigate what went wrong there; Cedric, any idea what changes
could have broken it again?

i am currently not sure if your patch is the right fix; i would assume
that the cursor that points to the removed node should have been moved
away from it by ... something.

but in any case thank you for investigating...

regards,
 michael