Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

Hello Christina,

2011/11/12 Chr. Rossmanith <ChrRossmanith@gmx.de>:
> To add some information: LibO builds fine but I keep getting failed tests in
> the end:
>
> make[1]: ***
> [/Space/LibreOffice_OneGit/core/workdir/unxlngi6.pro/CppunitTest/sc_filters_test.test]
> Fehler 1
>
> It's ./sc where I made modifications and sc_filters_test which fails...

This part might be worng:

         if ( bValue )
-            aString.AssignAscii( "###" );
-        aString.Erase( nLen );
+            aString = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( "###" ));

Could you paste the exact error message. Normally there should be a
better error message mentioning why the test did fail. Depending on
the place where it fails it should give a relative exact message which
cell is not as expected. Otherwise I'll have a look tomorrow evening.

I think it should fail in sc/qa/unit/data/ods/format.ods. You can
check this file yourself with your build and see what is different to
a 3-4 build.

Regards,
Markus