Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage

Eike Rathke <erack -AT- redhat.com>
Mon, 14 Nov 2011 15:11:21 +0100

Hi Markus,

On Saturday, 2011-11-12 16:11:09 +0100, Markus Mohrhard wrote:

This part might be worng:

         if ( bValue )
-            aString.AssignAscii( "###" );
-        aString.Erase( nLen );
+            aString = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( "###" ));


It is. The "###" was only assigned if the value was numeric, textual
values were truncated instead. The change now omits the truncation.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpKiF_NICvbz.pgp
Description: PGP signature

Context

[Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Chr. Rossmanith
- Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Chr. Rossmanith
  - Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Markus Mohrhard
    - Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Eike Rathke
      - Re: [Libreoffice] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Caolán McNamara
- Re: [Libreoffice] [PUSHED] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Noel Power
  - Re: [Libreoffice] [PUSHED] [PATCH][PLEASE REVIEW] Remove String::Fill() usage · Chr. Rossmanith

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.