Re: [Libreoffice] [PUSHED] [PATCH] translation german comments to english plus rename of define MAX_COL_HEIGHT

forgot to change the subject line to PUSHED, also the commit is here

http://cgit.freedesktop.org/libreoffice/core/commit/?id=98a10b638a645776d14049b8fb12a87b80b6eb3b

thanks,

Noel
On 11/11/11 15:02, Noel Power wrote:
> On 11/11/11 12:56, Winfried Donkers wrote:
> > (reply to list as well-together with attachment- is better, of course)
> >
> > >>First tiny contribution.
> >
> > >>Translated comments, also renamed define MAX_COL_HEIGHT to 
> > MAX_ROW_HEIGHT.
> >
> > >Erm, I think the attached patch is not the intended one right ( patch 
> > attached is something already committed )?
> >
> > I did it with 'git commit -a' followed by 'git format-patch 
> > filename', as read somewhere in this list. That may have been the 
> > wrong thing to do...
> No, that is the correct thing to do, since you were able to create 
> your patch with git diff it appears that you didn't actually commit 
> your changes ( and git format-patch only works with commits ). 
> Probably your commit failed and you didn't notice the error message.
>
> There is however another problem, if you look at your attached diff 
> you will notice that that complete contents of 
> sc/source/ui/view/cellsh3.cxx are marked as removed and then all lines 
> ( + your additions ) added into that file. What has happened *I 
> think*  is that whatever editor you are using is inserting windows 
> style (CR)(LF) line endings. The diff tool then thinks that each line 
> in the file has been replaced. You need to teach your editor not to do 
> that ( most editors should have a setting for that ).
> > The attachment now is made with 'git diff > filename'.
> >
> > I hope this one's better...
> >
> > I am sorry of making a mess of it!
> not at all, just teething problems :-) thanks for the nice patch.
> Finally can you confirm you contribution is under LGPLv3+ / MPL license
>
> thanks again,
> Noel