Re: [Libreoffice] [PATCH] translation german comments to english plus rename of define MAX_COL_HEIGHT

On 11/11/11 08:06, Winfried Donkers wrote:
> First tiny contribution.
>
> Translated comments, also renamed define MAX_COL_HEIGHT to MAX_ROW_HEIGHT.
>
> This patch is and future patches will be contributed under the LGPLv3+ 
> / MPL.
Erm, I think the attached patch is not the intended one right ( patch 
attached is something already committed )?
> By the way,
>
> should comments like
>
>             case FID_INS_COLUMN:        // insert columns
>
>             case SID_COPY:                      // Kopieren (translate 
> to copy)
>
> be translated or removed? I don't see any additional value in these 
> comments
The first imo has some value, INS_COLUMN might not be immediately 
obvious as meaning insert columns especially to non-native english 
speakers. The second I would delete, I don't think there is a hard and 
fast rule, just use common sense I guess

Noel