Re: [Libreoffice] [PATCH] translation german comments to english plus rename of define MAX_COL_HEIGHT

On Fri, Nov 11, 2011 at 01:40:51PM +0100, Winfried Donkers wrote:

> > > First tiny contribution.
> > > Translated comments, also renamed define MAX_COL_HEIGHT to MAX_ROW_HEIGHT.
> > Erm, I think the attached patch is not the intended one right ( patch attached is something 
> > already committed )?

> I did it with 'git commit -a' followed by 'git format-patch
> filename', as read somewhere in this list. That may have been the
> wrong thing to do...

"git commit -a" should have launched a text editor where you can write
a so-called "commit message", that is a short description of what you
did. If it did not, then please set your EDITOR environment variable
to something sensible, e.g. one of:

export EDITOR=vim
export EDITOR=emacs
export EDITOR=gedit
export EDITOR=kate

Which one depends on your tastes and which one you are used to.

After you finish writing the commit message and close the editor, git
*actually* does the commit. You can check that by running "git log"
and seeing your commit at the top. Only after that will "git
format-patch" do the right thing. AFAIK, you don't need a filename
argument after it, though. If you ask me, I'd tell you to use:

git format-patch remotes/origin/master

which means "prepare for email sending all patches that are in my
current branch, but not in remotes/origin/master". In this way, you
can cover several commits (several patches) in one command.

remotes/origin/master is the master branch on the git repo you cloned
from (as of the last time you did pull or fetch), which I'm guessing
is the "official" ones at freedesktop.org.

-- 
Lionel