Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

Hi Eike,

2011/11/2 Eike Rathke <erack@redhat.com>:
> Hi Markus,
>
> On Tuesday, 2011-11-01 22:45:57 +0100, Markus Mohrhard wrote:
>
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21
>
> Taking a second look, that patch would break handling of the case when
> the matrix is a valid 2D matrix with more than one column and more than
> one row. See implementation of ValidColRowReplicated(), which is not
> meant to be used in such a context, but to determine whether a col/row
> needs to be replicated in case the matrix is only a vector. If at all,
> the intended behavior could be realized using ValidColRowOrReplicated()
> instead, however, I currently don't remember why all Is*() methods don't
> use it whereas all Get*() methods do.

You're totally right. I did not notice that I used the wrong method
while I wanted to use the other method.

Pushed a fix to master:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b03e931439c54f4abaa520cf11ed24560ca1709a.
Could anyone push that to the 3-4 branch.


Thanks Markus

P.S. the commit message should be silly mistake by me