On Tue, 2011-11-01 at 22:45 +0100, Markus Mohrhard wrote:
Hey,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21
fixes a crash that happens if you use ROW() or COLUMN() in a matrix
function. We try to get an entry from an empty mdds container which
results in a crash.
Even that we are not sure that return true is always correct this
patch should be safe since this only matters in the case where a crash
would have happened.
Well, I'm still not 100% sure if this is the best way to fix this (as I
hinted in my private mail to you), but I will agree that 1) it's much
much better than crashing, and 2) the change only affects very rare
corner cases that it's a safe change.
Pushed to the 3-4 branch with my sign-off.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.