[Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

Markus Mohrhard <markus.mohrhard -AT- googlemail.com>
Tue, 1 Nov 2011 22:45:57 +0100

Hey,

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21
fixes a crash that happens if you use ROW() or COLUMN() in a matrix
function. We try to get an entry from an empty mdds container which
results in a crash.

Even that we are not sure that return true is always correct this
patch should be safe since this only matters in the case where a crash
would have happened.

Review and sign-off appreciated.

Markus

Context

[Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Markus Mohrhard
- Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Kohei Yoshida
- Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Eike Rathke
- Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Eike Rathke
  - Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Markus Mohrhard
    - Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Kohei Yoshida
      - Re: [Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas · Markus Mohrhard

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.