Re: [Libreoffice] [REVIEW 3-4] 3.4.4rc1 fails to build in kde4 vcl

On Mon, Oct 31, 2011 at 06:15:55PM +0100, Andreas Radke wrote:
> Am Mon, 31 Oct 2011 09:50:31 +0100
> schrieb David Tardon <dtardon@redhat.com>:
>
> > On Sun, Oct 30, 2011 at 10:55:34PM +0100, Rene Engelhard wrote:
> > > On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote:
> > > > On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
> > > > > Compiling: vcl/unx/source/dtrans/config.cxx
> > > > > /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function
> > > > > 'void KDEXLib::setupEventLoop()':
> > > > > /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
> > > > > 'GetUnixSelectFunction' is not a member of 'QInternal'
> > > > > /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
> > > > > 'SetUnixSelectFunction' is not a member of 'QInternal'
> > > > This is probably due to Qt 4.8 and not our bug I guess.
> > >
> > > Eh, no? If it needs fixes due to Qt 4.8, that should be done here
> > > so we compile against newer Qts.
> >
> > It has been done already. That code should only be used if
> > QT_UNIX_EVENT_LOOP_SUPPORT is defined, which, in turn, should only be
> > defined if Qt version is at least 4.8.1 . If there is no chance that
> > http://bugreports.qt.nokia.com/browse/QTBUG-16934 could be fixed in Qt
> > 4.8.1, we should IMHO bump the check to 4.9.0.
> >
> > D.
>
> Any chance you post a fix for 3.4.4 branch? Or I would have to disable
> the qt vcl for this release.

Oops, I thought I did that back in July... Unfortunately, we just missed
a deadline for 3.4.4 RC2 and I doubt this will be considered a blocker,
so you will have to wait for 3.4.5.

Could anyone sign-off commit 887b8ed0655fb59f9208058e811e5373b3928c2c in
libs-gui for 3.4?

D.