Re: [Libreoffice] 3.4.4rc1 fails to build in kde4 vcl

On Sun, Oct 30, 2011 at 03:15:49AM +0100, Andrea Scarpino wrote:
> On Saturday 29 October 2011 21:30:29 Andreas Radke wrote:
> > Compiling: vcl/unx/source/dtrans/config.cxx
> > /build/src/build/vcl/unx/kde4/KDEXLib.cxx: In member function 'void
> > KDEXLib::setupEventLoop()':
> > /build/src/build/vcl/unx/kde4/KDEXLib.cxx:252:34: error:
> > 'GetUnixSelectFunction' is not a member of 'QInternal'
> > /build/src/build/vcl/unx/kde4/KDEXLib.cxx:253:34: error:
> > 'SetUnixSelectFunction' is not a member of 'QInternal'
> This is probably due to Qt 4.8 and not our bug I guess.

Eh, no? If it needs fixes due to Qt 4.8, that should be done here
so we compile against newer Qts.

That said, WTF are we using Qt*Internal*? Looks quite internal
to Qt for me :), not something which is public and should be used?

$ grep -r QInternal *
unx/kde4/KDEXLib.cxx:        QInternal::callFunction( QInternal::GetUnixSelectFunction, 
reinterpret_cast< void** >( &qt_select ));
unx/kde4/KDEXLib.cxx:        QInternal::callFunction( QInternal::SetUnixSelectFunction, 
reinterpret_cast< void** >( lo_select ));

in boith 3.4.4 and master.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70