Re: [Libreoffice] [PATCH] ant/dmake to gbuild conversions

Hi Peter, Michael, all,

On Fri, 23 Sep 2011 11:12:38 +0100
Michael Meeks <michael.meeks@novell.com>
wrote:

>       Clearly there is then no prohibition on using ant, or
> external / java packages that require it - but Peter's patches seem
> to convert two of the five modules using ant to (cleaner) gnu make
> files in the process and leave only: beanshell scripting and xmerge
> requiring ant.
>
>       Seems like progress to me, I'd love to see that included.

I would have to agree. The patches look pretty clean(*) and look way
better than the original codegenerated ant build.xmls. I also agree
that we should stick with ant for _external_ projects that use it as
their buildsystem (and not plug in our own build system like had been
done with dmake at a few places), but for the modules in question now
gbuildifying them seems to be a good thing. So: no objections --
actually quite fine work there, Peter!

Best,

Bjoern

(*) But as with all things build system you need tinderboxes to be sure.
-- 
https://launchpad.net/~bjoern-michaelsen