Re: [Libreoffice] [PATCH] convert Mesa to gbuild

argh... bjorn use of gmane screw-up my reply-all thing...

On Wed, Sep 7, 2011 at 5:04 PM, Norbert Thiebaud <nthiebaud@gmail.com> wrote:
> On Wed, Sep 7, 2011 at 4:24 PM, Bjoern Michaelsen
> <bjoern.michaelsen@gmail.com> wrote:
> > On Wed, 7 Sep 2011 15:32:21 -0500
> > Norbert Thiebaud <nthiebaud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > wrote:
> >
> > > I wonder would that work dep wise to just have a packaging step ?
> >
> > $(call gb_Library_get_headers_target,libthatneedsmesa) : \
> > $(call gb_Package_get_target,Mesa_inc)
>
> will, try that...  that should be enough for now... Altough IIRc I did
> incorrectly use _add_api somewhere else when I needed just that
> above... so maybe a formal api could be good (well, with also some doc
> :-) -- btw my idea to use doxygen directly on the .mk file did not fly
> at all :-( )
>
> > Of course, we could create a new name for that, but IMHO that is simple
> > enough as is.
> >
> > > > ok, fits in better with the other RepositoryFoo.mk stuff.
> > > > but why not just RepositoryModule.mk?
> > >
> > > Some hope/anticipation that there may be more than one product sharing
> > > the same spaces ?  not sure...
> >
> > Not only hope, but actually a hard requirement. There has been this
> > other product which was closely related to OOo, you know ...
> >
> > Also: solenv/gbuild was originally created to be project-agnostic, and
> > in theory the contents of that dir should be independent of the first
> > project which happens to use it. And gbuild needed to be able to build
> > multiple sources from independent repositories (without resorting to
> > dirty symlink tricks -- exactly the stuff that did bite us on cygwin
> > then).
>
> I'm afraid I probably already mis-implemented the gb_Repos thing
> (pretty sure that in the yacc support, I did not handle that right)
>
> Norbert