Re: [Libreoffice] [PATCH] convert Mesa to gbuild

On Wed, Sep 7, 2011 at 2:45 PM, Michael Stahl <mst@openoffice.org> wrote:
> On 07.09.2011 21:15, Peter Foley wrote:
> > This is my first attempt at converting a module to gbuild so I'd
> > appreciate it if someone knowlegeable about gbuild could take a look.
> >
> > Thanks,
> >
> > Peter
>
> hi Peter,
>
> looks good, didn't know we have such a simple module :)

I wonder would that work dep wise to just have a packaging step ?
> only thing missing is that you should add the module to the top-level
> Module_ooo.mk.

and also tell the slideshow module to depend on it (right now it is
done via build.lst... but Mesa can be integrated to tail_build, as it
fulfill the requirement to do so)
which might be a problem since I don't know that we have an api to
declare pure include-packaging mode dep... the closest thing we have
is gb_LinkTarget_add_api, but it is an overkill here as it try to add
stuff in $INCLUDE...


> actually it seems somebody renamed it to RepositoryModule_ooo.mk.

yep, because there was a clash with Module_tail_build.mk (which needed
to be at the root) and the fact the gmake search for anything Module_*
, so it was accidentally picking up Module_ooo.mk. Hence the rename.

> ok, fits in better with the other RepositoryFoo.mk stuff.
> but why not just RepositoryModule.mk?

Some hope/anticipation that there may be more than one product sharing
the same spaces ?  not sure...

Norbert