Hi Korrawit,
On Tuesday, 2011-09-06 21:52:46 +0700, Korrawit Pruegsanusak wrote:
And please s/interger/integer ;)
Did that in the commit.
Also, it seems that you haven't check the range of ishift yet, whether
it is between -48 and 48 (from your description), or it isn't
necessary? I don't have knowledge on this.
Actually those don't have to be restricted and I implemented another
algorithm to support larger values.
My last nitpick, what about the strings capitalization?
Also did that.
Eike
--
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
signature.asc
Description: Digital signature
Context
Re: [Libreoffice] [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
Re: [Libreoffice] [PUSHED] new BITxxx functions for ODF 1.2 · Eike Rathke
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.