Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2

Korrawit Pruegsanusak <detective.conan.1412 -AT- gmail.com>
Tue, 6 Sep 2011 21:52:46 +0700

Hello all,

On Tue, Sep 6, 2011 at 20:08, Niko Rönkkö <niko.ronkko@wippies.fi> wrote:

Hi

Wonderful, great stuff - I have to apologize, the many whitespace
changes in the calc part of the patch are because of my substandard
mentoring - cleaned-up version of the first patch attached.


I was in the belief that we shall use spaces instead of tabs.

Corrected patches attached.


And please s/interger/integer ;)
Also, it seems that you haven't check the range of ishift yet, whether
it is between -48 and 48 (from your description), or it isn't
necessary? I don't have knowledge on this.
My last nitpick, what about the strings capitalization?

Best Regards,
-- 
Korrawit Pruegsanusak

Context

[Libreoffice] [Patch] new BITxxx functions for ODF 1.2 · libo
- Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Thorsten Behrens
  - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Olivier Hallot
    - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
      - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Olivier Hallot
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
  - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Niko Rönkkö
    - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Korrawit Pruegsanusak
      - Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Regina Henschel
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Stephan Bergmann
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Noel Grandin
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Tor Lillqvist
        
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Regina Henschel
        Re: [Libreoffice] Updated [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
- Re: [Libreoffice] [Patch] new BITxxx functions for ODF 1.2 · Eike Rathke
- Re: [Libreoffice] [PUSHED] new BITxxx functions for ODF 1.2 · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.