Re: [Libreoffice] [PUSHED] Bringing some sanity to interline spacing

Khaled Hosny <khaledhosny -AT- eglug.org>
Thu, 1 Sep 2011 03:08:09 +0200

On Thu, Sep 01, 2011 at 02:13:34AM +0200, Eike Rathke wrote:

Hi Khaled,

On Monday, 2011-08-29 20:21:47 +0200, Khaled Hosny wrote:

Wow, way cool stuff! :-)

:)

#38683[5] is another example of problems caused by this.


I'll set that bug to fixed with a remark to verify as I don't have
a usable font for this.

This only done for 'unx' similar work is needed for 'win' and 'aqua',
but I'm not familiar with these platforms and can't test on it.


Is handling on those platforms similar broken?


I did no testing, and I'm not familiar with other platforms APIs, but
there seem to be a nCJKExtLeading hack in vcl/win/source/gdi/salgdi3.cxx
and a comment above it suggests that typo metrics are not currently used.

Btw, please tag mails with attached patches with [PATCH] in the subject.


Sorry, missed that.

Regards,
 Khaled

-- 
 Khaled Hosny
 Egyptian
 Arab

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
- Re: [Libreoffice] [PUSHED] Bringing some sanity to interline spacing · Eike Rathke
  - Re: [Libreoffice] [PUSHED] Bringing some sanity to interline spacing · Khaled Hosny
- Re: [Libreoffice] Bringing some sanity to interline spacing · Tor Lillqvist
  - Re: [Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
    - Re: [Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
  - Re: [Libreoffice] Bringing some sanity to interline spacing · Caolán McNamara
    - Re: [Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
      - Re: [Libreoffice] Bringing some sanity to interline spacing · Caolán McNamara
        
        Re: [Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
        
        Re: [Libreoffice] Bringing some sanity to interline spacing · Caolán McNamara
        
        Re: [Libreoffice] Bringing some sanity to interline spacing · Khaled Hosny
        Re: [Libreoffice] Bringing some sanity to interline spacing · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.