Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code

Eike Rathke <ooo -AT- erack.de>
Thu, 1 Sep 2011 03:07:36 +0200

Hi Khaled,

On Thursday, 2011-09-01 02:54:36 +0200, Eike Rathke wrote:

Nice clean-up, pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6825533b8d93f92a66558a9b6295003ceba52917


Forgot to mention [PUSHED] in the subject and that I changed all

+#define isAinChar(c)        IS_JOINING_GROUP(c, AIN)

to have parentheses around the macro parameter's use

+#define isAinChar(c)        IS_JOINING_GROUP((c), AIN)

[otherwise macros are evil anyway ;-]

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] [PATCH] some cleanup of Kashida justification code · Khaled Hosny
- Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code · Eike Rathke
  - Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code · Eike Rathke
    - Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code · Khaled Hosny
      - Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code · Kohei Yoshida
        
        Re: [Libreoffice] [PUSHED] some cleanup of Kashida justification code · Khaled Hosny
  - Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code · Matúš Kukan
    - Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code · Caolán McNamara
      - Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code · Caolán McNamara
- Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.