Re: [Libreoffice] [PATCH] some cleanup of Kashida justification code

Hi,

On 1 September 2011 02:54, Eike Rathke <ooo@erack.de> wrote:
> Hi Khaled,
>
> On Thursday, 2011-09-01 01:28:28 +0200, Khaled Hosny wrote:
>
> > While trying to fix the eternal brokenness of Kashida justification code,
> > I found some low hanging cleanups. See attached patches.
>
> Nice clean-up, pushed to master
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6825533b8d93f92a66558a9b6295003ceba52917
I don't have U_JG_FARSI_YEH defined in my old system icu 4.2.1.
Maybe this could be pushed? or something similar ?

diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index ef50056..bcb3dc9 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -82,7 +82,11 @@ using namespace i18n::ScriptType;
 #define isRehChar(c)        IS_JOINING_GROUP((c), REH)
 #define isTehMarbutaChar(c) IS_JOINING_GROUP((c), TEH_MARBUTA)
 #define isWawChar(c)        IS_JOINING_GROUP((c), WAW)
+#ifdef U_JG_FARSI_YEH
 #define isYehChar(c)        (IS_JOINING_GROUP((c), YEH) ||
IS_JOINING_GROUP((c), FARSI_YEH))
+#else
+#define isYehChar(c)        IS_JOINING_GROUP((c), YEH)
+#endif
 #define isSeenOrSadChar(c)  (IS_JOINING_GROUP((c), SAD) ||
IS_JOINING_GROUP((c), SEEN))

 sal_Bool isTransparentChar ( xub_Unicode cCh )

thanks,

Matúš