On Mon, 2011-08-22 at 09:13 -0400, Kohei Yoshida wrote:
Your patch remove only the first nCol--. It looks a bit asymmetric. Of
course, it might be correct but...
I had already commented in bugzilla, but the patch not only breaks the
symmetry it changes the expected behavior. So, it's not the right way
to fix it.
Also, when working on this EasyHack, please do
1) try to check the size of the current selection at the start of the
method, and if the selection contains only one cell, check that cell,
and return immediately, and
2) do test all the find and replace functionality to make sure nothing
is broken. This means you need to familiarize yourself with what the
current functionality is, what options are available so that you can
test it thoroughly using various search options. In the latest code
Ctrl-F is bound to the find bar, so you need to launch the old dialog by
Ctrl-Alt-F or from the menu Edit - Find & Replace... and see what search
options are available there.
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida@suse.com>
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.