On Mon, 2011-08-22 at 14:49 +0200, Petr Mladek wrote:
I did a quick look and the patch looks suspicious to me. The code is
like:
if
if
nCol--;
else
nRow--;
fi
else
if
nCol++;
else
nRow++;
fi
Your patch remove only the first nCol--. It looks a bit asymmetric. Of
course, it might be correct but...
I had already commented in bugzilla, but the patch not only breaks the
symmetry it changes the expected behavior. So, it's not the right way
to fix it.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida@suse.com>
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.