Re: [Libreoffice] [REVIEW] Patch for #36800: "Find & replace" does not search single cell

Hi Kohei, Marcus,

could you please have a look.

Nguyen Vu Hung píše v St 17. 08. 2011 v 11:05 +0700:
> Hello all,
>
> mhst has done the patch for #36800 which turns out to be an one-line fix.
>
> Can anyone take a look at this and commit to the 3.4.x?
>
> cf.
> The bug: https://bugs.freedesktop.org/show_bug.cgi?id=36800
> The patch: https://bugs.freedesktop.org/attachment.cgi?id=49770

I did a quick look and the patch looks suspicious to me. The code is
like:

if
    if
        nCol--;
    else
        nRow--;
    fi
else
    if
        nCol++;
    else
        nRow++;
fi

Your patch remove only the first nCol--. It looks a bit asymmetric. Of
course, it might be correct but...

Best Regards,
Petr