Hi Maciej, On Thursday, 2011-08-04 18:57:11 -0400, Kohei Yoshida wrote:
If I see any sal_Bool (sal_True, sal_False), should I change it to standard bool?Absolutely! *But* take at least a cursory look to make sure that it is really used as a boolean value. sal_Bool is a typedef to an 8-bit integer, and some code does abuse this fact and use it more like an enum. You probably don't see very many uses of such abuse, but they are there in some corners.
And of course where sal_Bool is exposed to the UNO API it shall not be changed to bool. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
pgpqtn3OKnWIR.pgp
Description: PGP signature