Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Maciej Rumianowski <maciej.rumianowski -AT- gmail.com>
Thu, 04 Aug 2011 23:23:43 +0200

Dnia 2011-08-04, czw o godzinie 12:09 -0400, Kohei Yoshida pisze:

On Thu, 2011-08-04 at 00:40 +0200, Maciej Rumianowski wrote:

Ok.  The new patch looks good (to me).  Pushed to master.


Thanks :)

Other than that, the rest looks okay to me.  I'd prefer someone more
experienced in Writer's code to sanity-check though.


O, so by the way there is in wrtww8.hxx a VARARR WW8Bytes which should
be migrated to ww::bytes. Is it okay to do?


Yeah, that looks reasonable.  Unless someone who knows more about
writer's code than I objects, and objects soon, I'd say go for it. :-)


Okay so I will work further on SvULongs, there is some in libs-gui, and
than come back to writer.

Best,
    Maciej

Context

[Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Maciej Rumianowski
- Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Kohei Yoshida
  - Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Maciej Rumianowski
    - Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Kohei Yoshida
      - Re: [Libreoffice] [PATCH] [PUSHED] Easy Hack - Get rid ofSvULongs in writer · Kohei Yoshida
      - Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Maciej Rumianowski
        
        Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Maciej Rumianowski
        
        Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Kohei Yoshida
        
        Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.