Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Fri, 2011-08-05 at 00:29 +0200, Maciej Rumianowski wrote:
Dnia 2011-08-04, czw o godzinie 23:23 +0200, Maciej Rumianowski pisze:
Okay so I will work further on SvULongs, there is some in libs-gui,
and
than come back to writer. 

Sorry, I meant libs-core.

If I see any sal_Bool (sal_True, sal_False), should I change it to
standard bool?

Absolutely!  *But* take at least a cursory look to make sure that it is
really used as a boolean value.  sal_Bool is a typedef to an 8-bit
integer, and some code does abuse this fact and use it more like an
enum.  You probably don't see very many uses of such abuse, but they are
there in some corners.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida@suse.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.