On Tue, Aug 02, 2011 at 05:51:49PM +0100, Noel Power <nopower@novell.com> wrote:
On 02/08/11 16:46, Miklos Vajna wrote:I guess the reason is that the doc shell points to the whole document, while you usually export only part of the doc during copy&paste export.'copy&paste export' is it a new thing you can't normally do from writer ? ( not familiar with it anyway )
No, it's not new at all. The only recent change was that you changed SwMSConvertControls to require a valid SwDocShell. Given that SwMSConvertControls is called by MSWordExportBase, and copy&paste export (when RTF format is selected and which uses MSWordExportBase) does not provide a SwDocShell (AFAIK it never did, but it wasn't a problem till now).
And yes, I don't think missing the control export is a big issue (at least it's a smaller one thatn the current instant crash),yes of course and no problem for me with the fix for that
OK, I've pushed the patch.
Attachment:
pgpVFXoQaxtAX.pgp
Description: PGP signature