Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

Noel Power <nopower -AT- novell.com>
Tue, 02 Aug 2011 10:07:22 +0100

Hi Miklos
On 01/08/11 19:26, Miklos Vajna wrote:

Hello Noel,

I recently tested the copy&paste export (using RTF) on master and got a
crash. The attached patch solves the issue here.

OK to push, or you want to add a check in the called SwMSConvertControls
constructor?

actually I am not at all familiar with the export side of this stuff. Intheory I think your check is ok ( unfortunately I would guess theexpectation that the doc shell is valid is probably buried deep in theSvxMSDffManager implementation ( where it probably isn't checked either ) )

but... I wonder why the doc shell isn't set up in the case of the RTFexport ( is this something expected ) will this screw up other thingslater on. Also for the case above is the control export something thatis relevant for the RTF filter even ?


sorry haven't helped much :-(

Noel

Context

[Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Miklos Vajna
- Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Noel Power
  - Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Miklos Vajna
    - Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Noel Power
      - Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Miklos Vajna
        
        Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.