Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

Hi Noel,

On Tue, Aug 02, 2011 at 10:07:22AM +0100, Noel Power <nopower@novell.com> wrote:
> actually I am not at all familiar with the export side of this stuff. In 
> theory I think your check is ok ( unfortunately I would guess the 
> expectation that the doc shell is valid is probably buried deep in the 
> SvxMSDffManager implementation ( where it probably isn't checked either ) )

Sure, that's why I touched the caller.

> but... I wonder why the doc shell isn't set up in the case of the RTF 
> export ( is this something expected )  will this screw up other things 
> later on.  Also for the case above is the control export something that 
> is relevant for the RTF filter even ?
>
> sorry haven't helped much :-(

I guess the reason is that the doc shell points to the whole document,
while you usually export only part of the doc during copy&paste export.

And yes, I don't think missing the control export is a big issue (at
least it's a smaller one thatn the current instant crash), that's why I
asked if you're fine with pushing the patch I sent.

Thanks.

Attachment: pgpiuNlxS0Fqe.pgp
Description: PGP signature