Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index



Please let me know if it looks problematic

Looks great :)

--
Regards Jonas Finnemann Jensen.


On Fri, Jul 15, 2011 at 18:25, Miklos Vajna <vmiklos@frugalware.org> wrote:

Hi Jonas,

On Fri, Jul 15, 2011 at 01:45:42PM +0200, Jonas Finnemann Jensen <
jopsen@gmail.com> wrote:
Your patch looks good, have you pushed it?

I just did so.

I don't think it hides a deeper problem (except lack of comments :) ), as
far as I remember there're other places where pViewShell->GetEditWindow()
is
NULL tested. Also the method explicity returns NULL when the edit window
doesn't exists (I'm guessing either not created yet, or disabled).
 - So I think it's okay.

Here is a second commit that fixes a similar crash when experimental
features are enabled (in particular your inline editor):


http://cgit.freedesktop.org/libreoffice/writer/commit/?id=94959497c0a9fe956f0b12a35ae98148db25bd62

Please let me know if it looks problematic. (The story is simpler in
this case: try to load
http://people.freedesktop.org/~vmiklos/math.word2007.docx, double click
on the formula and Math will crash instantly.)

By the way, nice to see that you're working GSoC again this year.

:)


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.