Re: [Libreoffice] [REVIEW 3-4] [PUSHED 3-4] Update mdds to 0.5.3

On Wed, Jul 13, 2011 at 11:15:33PM -0400, Kohei Yoshida wrote:
> Hi there,
>
> I'd like to update mdds to 0.5.3 for the -3-4 branch and preferably the
> -3-4-2 branch as well.  The attached patches would make that happen.
>
> That should improve the performance issue raised in
>
> https://bugs.freedesktop.org/show_bug.cgi?id=38028
>
> but since this affects the general performance of the matrix code, it
> should speed up calculations involving matrices in other use cases as
> well.
>
> I've already updated mdds to 0.5.3 on master, so this is for the 3.4.x
> branch only.
>
> The change in mdds since 0.5.2 is very minimal.  In fact, the only
> change I made is in the filled matrix storage backend code, and the new
> implementation passes all the tests therein (on Linux and Windows).
> Memory leak tests show no leakages.

Looks good to me.

Nitpick, unrelated to the review: you may want to disable operator= for
storage_filled_linear (and storage_filled_nested_array too), because its
use would cause double delete. (I would even make the copy ctors of all
the storage classes protected to ensure that only clone() is ever used
to create copies, but since the classes are only used in implementation,
the danger of that happening is probably very low...)

D.