Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar

On 04/07/11 11:29, Anurag Jain wrote:
> Hello Noel,
>
> I'm sending the inputwin.cxx with the changes I've made in
> ScInputBargroup. Do not push it as of now. I'd be making some more
> changes as mentioned in above mail before it can be pushed.
I guess it really isn't usable without a header file :-( I really was 
looking for a patch that addressed the issues we talked about previously 
that would allow me to at least start to try and integrate your work.

> On Mon, Jul 4, 2011 at 3:53 PM, Anurag Jain<anuragjainfzd@gmail.com>  wrote:
> > Hello Noel,
> >
> > Yes I have made some changes as you mentioned this weekend. There are
> > certain thing I'm not getting properly.
> >
> > 1: I'm able to toggle the height of ScMultiBar and ScInputBarGroup on
> > button click. But the increment happens inside the ScInputWindow i.e.
> > the excess window size do not appear. It toggles inside the
> > ScInputWindow. To make it look the height of complete panel should be
> > varied.So in order to do that will it be a good idea to add a
> > ScInputWindow object in ScInputBarGroup and use it to vary the whole
> > panel's height ?
hmm, it seems that somehow the toolbar doesn't resize as expected, don't 
know why, might be worth doing some debugging in 
vcl/source/window/toolbox.cxx
> > 2: Also one more thing, when button is clicked twice , the position
> > window, and other formula images all disappears leaving a blank on
> > left side of panel. I guess the ScInputBarGroup changes its vertical
> > position. I tried resetting it always to (nLeft,0) but the LO did not
> > start for some reason. As of now I'm trying to fix that. I'll discuss
> > about these problems today in IRC and things required to be improved a
> > little bit before putting it in master branch.
no idea at all about that, it sounds like either a paint problem ( but 
that's easy to check by forcing repaint but moving the window offscreen 
and back ) or the controls have been repositioned somehow, again some 
debugging of the size and position attributes of the toolbar items 
should give you an idea

I am going to try to integrate the code as it was before whatever new 
work you have done because I there is little time left, it is better to 
have some code integrated rather than none :-). I didn't look at the 
inputwin.cxx that you attached in any great detail but I don't like the 
name of the new textbox ScMultiBar, it is I think misleading, I liked 
some of the other alternatives you suggested better ( e.g. ScMultiText ).
I know I suggested that you rename the class to something new but I 
thought maybe you could reuse the old one ( e.g. inherit from it ) to 
avoid duplicating *all* the code there. My main concern was to separate 
the new from old code ( without excessive logic ( if/then ) branches in 
the code especially with the requirement of having some code in master 
)... I will try to fix that when integrating the code

Noel