Re: [Libreoffice] Unused files in the impress repository

Hi Christian,

On Mon, Jul 04, 2011 at 01:22:21PM +0200, Christian Lohmaier wrote:
> On Sat, Jul 2, 2011 at 10:12 PM, Francois Tigeot <ftigeot@wolfpond.org> wrote:
> > The following files seem to be unused:
> >
> >  impress/sd/source/filter/eppt/eppt.cxx
> >  impress/sd/source/filter/html/htmlex.cxx
> >
> > With the attached patch, I could succesfully complete a build. Howewer,
> > I'm not 100% sure these files have no purpose whatsoever.
>
> Well, stating the obvious (hopefully it is obvious for you as well):
> As htmlex is dealing with html export - is html export still available
> and working in Impress? Same with ppt export.

Good question, I had not done an installation in a while ;)

The html and ppt save/export options are still available
And they are not working anymore:

Trying to export as html crashes LibreOffice:

  /usr/libexec/ld-elf.so.2:
  /usr/local/LibreOffice/program/../basis-link/program/libsdlo.so: Undefined symbol 
"_ZN10HtmlExportC1EN3rtl8OUStringERKN3com3sun4star3uno8SequenceINS4_5beans13PropertyValueEEEP14SdDrawDocumentPN2sd12DrawDocShellE"

Saving a file as .ppt opens a dialog box:

  Error saving the document Presentation:
  Write Error.
  The file could not be written.
  [OK]

> And regarding completing a build with the changes: A full, clean build
> from scratch, or a <do a build, do the change, run make again> build?
> The latter is not a guarantee to report "success" after removing files.

It was a build from scratch.

I now see that I was mistaken: even though none of the symbols from these
files are directly used in LibreOffice, the binary containing them is
loaded explicitely at run time, bypassing the normal shared library linking
mechanism.

I thought UNO was a sort of interface for external plugins but these export
functions also use it :-(

-- 
Francois Tigeot