Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Sun, 2011-07-03 at 23:07 +0200, Benoit Dolives wrote:

Yup, patch fixes fixes the problem. Thanks for this. Pushed now to
master.

Can you confirm that this is under our preferred LGPLv3+/MPL license
combo ?

Concerning your open question, the proposed patch checks if the
searched string belongs to the selection by using the same mechanism
as the common search command. Therefore it should have the same
behaviour as the search command in both cases (common or advanced
search/replace).

Hmm, if I stick e.g. Apple banana in there, select nothing, search and
replace with regular expression of b.*a to match banana but where the
search string has a different length to the text it will match, with
"comments" enabled, then that one doesn't replace.

AFAICS that "length is the same" branch is just an optimization. When
removed everything works as I would expect, so I pushed that as a follow
up fix. 

Would be good if you could double-check my changes there, and if the
equal length code is based on some other code elsewhere, there might be
an additional fix needed for the legacy stuff too.

There's probably a few more gotchas with search and replace in writer,
(e.g. how come I can't use "replace all" when comments are selected) if
you dig around bugzilla for them :-)

C.



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.