Re: [Libreoffice] [PATCH] Writer: Bug 36181 - EasyHack: Replace with "Notes" option doesn't work with text selected

Hi Caolán, all,

Concerning your open question, the proposed patch checks if the searched
string belongs to the selection by using the same mechanism as the common
search command. Therefore it should have the same behaviour as the search
command in both cases (common or advanced search/replace).

Best Regards,

--
Benoit

2011/7/2 Caolán McNamara <caolanm@redhat.com>

> On Fri, 2011-07-01 at 01:08 +0200, Benoit Dolives wrote:
> > Hi,
> >
> >
> > Please find in attachment the patch for the bug 36181.
>
> initially looks good, unless someone else has a look before Monday I'll
> take this one for review then. Only open question I have, without
> reading the bug report or building sw with the patch, is if it
> does-the-right-thing if the search/replace is one of the regular
> expression "advanced" search/replaces ?
>
> C.


-- 
Benoit Dolives