Re: [Libreoffice] [PATCH] Replace List with std::vector

Hi Joseph,

On Thu, 2011-06-23 at 20:41 -0700, Joseph Powers wrote:
> Ok, this patch compiles fine; however, I can't find where it's used.
> Also, I think it's unused; it looks a lot like leftovers of when
> OpenOffice had a web browser. If some can verify, that it's trash, a
> few pointers in to how to remove it would be nice.
>
> It looks like libs-gui/uui/source/services.cxx registers the component
> and sets up the factory for generating the dialogs. Because it's a
> component system, I'm not sure how to unplug it and/or verify how it
> would be used.

the code looks dead to me as well, but I am also not sure. It was
imported in 2000 and no real changes were done to it later - I mean the
cookiedlg.cxx. You might try to find out places where the component is
instantiated and check whether cookie dialog is still used. I tried
quickly to look it up and found few .java sources, but it will need
closer look I am afraid.

I am Cc-ing Thorsten, maybe he knows more about history of that part.

Looking at your patch I wonder if you should delete pCookies at the end
of _handleCookiesRequest method. It is created in this part:

> @@ -84,7 +72,7 @@ handleCookiesRequest_(
>          rContinuations)
>      SAL_THROW((uno::RuntimeException))
>  {
> -    CookieList aCookies;
> +    CntHTTPCookieList_impl* pCookies = new CntHTTPCookieList_impl();
>      for (sal_Int32 i = 0; i < rRequest.Cookies.getLength(); ++i)
>      {
>          try

Cheers
Radek