Re: [Libreoffice] [PATCH] [PUSHED:master] Fix for Bug 37484 - On any animation change, current position in list is lost

On Wed, 2011-06-22 at 05:03 -0600, Tor Lillqvist wrote:
> Thanks. If these work fine on Linux (i.e. X11), they can't be awfully
> broken on other windowing systems either, I hope. Pushed to master.

I run into a crash on startup in that part. I quickly fixed it, but it
might be better if you check that it plays nicely with your new code. Or
maybe make the ScrollToAbsPos not crash when called with unexpected
values, -1 for example.

It was happening when starting impress without loading presentation. I
guess you checked it only while loading presentation containing custom
animations?

Cheers
Radek

the quick fix:

commit 4be38046a5c2576b5b97ac47f7c0ea17444524ea
Author: Radek Doulik <rodo@novell.com>
Date:   Fri Jun 24 17:10:22 2011 +0200

    quick fix to avoid crash on impress's start

diff --git a/sd/source/ui/animations/CustomAnimationList.cxx
b/sd/source/ui/animations/CustomAnimationList.cxx
index 196fc53..cfb8463 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -742,7 +742,7 @@ void CustomAnimationList::update()
             // An entry has moved down out of view; scroll down one.
             ScrollToAbsPos( nFirstVis + 1 );
         }
-        else
+        else if ( nFirstVis != -1 )
         {
             // The selection is still in view, or it hasn't moved.
             ScrollToAbsPos( nFirstVis );