Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

On Tue, 2011-05-31 at 22:29 -0400, Kohei Yoshida wrote:
> in ScTabViewShell::Construct(), which I find a bit awkward as the doc
> options and the app options (presumably for the VBA API) fight each
> other in a bit weird way.  I would like to have this cleaned up a bit,
> but we can do this cleanup later after integrating your patch, since
> this may become a bit tricky depending on what VBA API requires. 

After looking around this a bit, I think it makes sense to

1) merge these two options storing the same thing, and
2) have it in ScAppOptions, not ScDocOptions.

Option values in ScDocOptions appear to be stored with the document as
well as with the configuration, whereas those in ScAppOptions are stored
with the configuration only.  Since it makes no sense to store the new
document settings with each document, it probably should belong to
ScAppOptions.

This also means that I've misplaced several options in ScDocOptions as
well.... The formula and compatibility options are not stored with the
document, so they should really be in ScAppOptions.  I need to fix that
later.... :-P

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>