Re: [Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

On Sat, Jun 11, 2011 at 01:48, Miklos Vajna <vmiklos@frugalware.org> wrote:
> On Fri, Jun 10, 2011 at 10:34:39PM +0200, Albert Thuswaldner <albert.thuswaldner@gmail.com> wrote:
> > --- /dev/null
> > +++ b/sc/source/ui/optdlg/tpdefaults.cxx
> > @@ -0,0 +1,87 @@
> > +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
> > +/*************************************************************************
> > + *
> > + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> > + *
> > + * Copyright 2010 Novell, Inc.
> > + *
> > + * LibreOffice - a multi-platform office productivity suite
> > + *
> > + * This file is part of LibreOffice.
> > + *
> > + * LibreOffice is free software: you can redistribute it and/or modify
> > + * it under the terms of the GNU Lesser General Public License version 3
> > + * only, as published by the Free Software Foundation.
> > + *
> > + * LibreOffice is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU Lesser General Public License version 3 for more details
> > + * (a copy is included in the LICENSE file that accompanied this code).
> > + *
> > + * You should have received a copy of the GNU Lesser General Public License
> > + * version 3 along with LibreOffice.  If not, see
> > + * <http://www.openoffice.org/license.html>
> > + * for a copy of the LGPLv3 License.
>
> Nitpicking: Why don't you use the TEMPLATE.SOURCECODE.HEADER file from
> the bootstrap root, which includes MPL and retains copyright?

Oh, well I didn't know about that until now. :)
Also the two new files in the patch are basically copies of
tpcompatibility.cxx/hxx (although significantly altered) that's why I
kept the header as is. What's the right thing to do in these
situations?

/Albert

> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice