Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one

Cedric Bosdonnat <cedric.bosdonnat.ooo -AT- free.fr>
Wed, 25 May 2011 10:03:39 +0200

Hello Markus,

On Tue, 2011-05-24 at 21:35 +0200, Markus Mohrhard wrote:

here is a short patch that sets all specified borders during parsing
instead of only one border. The problem was that nBorderTyp was set
for every border with the correct value but SetBorderLine was only
called once after the do while loop. So now every time nBorderType
will be overriden, I call SetBorderLine.


If this patch is ok I think we should add it to the 3-4 branch.


Sounds OK to me as the \brdr[tblr] are the first commands of a border
definition.

Many thanks for the fix.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr

Context

[Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Markus Mohrhard
- Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Cedric Bosdonnat
- Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Jan Holesovsky
  - Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Cedric Bosdonnat
    - Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Markus Mohrhard
      - Re: [Libreoffice] [Review] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Cedric Bosdonnat
        
        Re: [Libreoffice] [Review][PUSHED3-4] set all borders correctly in SvxRTFParser::ReadBorderAttr instead of only one · Petr Mladek

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.