Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

"Tor Lillqvist" <tlillqvist -AT- novell.com>
Mon, 23 May 2011 10:02:03 -0600

Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef
WIN conditionals in files built only on windows (I hope) ;-)


Actually I think OOo uses WIN  to mean 16-bit Windows 3.x...(and Win9x?), at least in some 
contexts. It is WNT that it uses to indicate 32-bit Windows.

See for instance http://opengrok.libreoffice.org/xref/libs-core/fpicker/test/makefile.mk#83 where   
.IF "$(GUI)" == "WIN"   is used around stuff that clearly is only for 16-bit Windows.

Yes, the mind boggles, such stuff still around in the codebase.

(Of course it might be possible that in some places WIN is used also for 32-bit Windows.)

--tml

Context

[Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Chr. Rossmanith
- Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Michael Meeks
  - Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Tor Lillqvist
- Re: [Libreoffice] [PATCH] [PUSHED] __cdecl -> SAL_CALL (libs-gui) · Lubos Lunak
- Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (calc/components/ure/writer) · Chr. Rossmanith
  - [Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer) · Michael Meeks
    - Re: [Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer) · Chr. Rossmanith
      - Re: [Libreoffice] [PUSHED] [REALLY] __cdecl -> SAL_CALL (calc/components/ure/writer) · Thorsten Behrens

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.