Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

Michael Meeks <michael.meeks -AT- novell.com>
Mon, 23 May 2011 16:38:45 +0100

Hi Christina,

On Mon, 2011-05-23 at 10:02 +0200, Chr. Rossmanith wrote:

the attached patch removes __cdecl and uses SAL_CALL instead. For future 
work: I suppose that I can omit files having win32 in their path?


        Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef
WIN conditionals in files built only on windows (I hope) ;-)

Compiles fine for me but make check never completed without errors. What 
shall I do with these error messages? IRC or post to list and hope for 
help or accept that they exist  :-)


        Are the errors different before / after the patch I guess is the
question :-) 'make check' passes for me - I tried to apply the patch to
checkthat, but it didn't apply to master (sorry).

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

Context

[Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Chr. Rossmanith
- Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Michael Meeks
  - Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui) · Tor Lillqvist
- Re: [Libreoffice] [PATCH] [PUSHED] __cdecl -> SAL_CALL (libs-gui) · Lubos Lunak
- Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (calc/components/ure/writer) · Chr. Rossmanith
  - [Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer) · Michael Meeks
    - Re: [Libreoffice] [PUSHED] __cdecl -> SAL_CALL (calc/components/ure/writer) · Chr. Rossmanith
      - Re: [Libreoffice] [PUSHED] [REALLY] __cdecl -> SAL_CALL (calc/components/ure/writer) · Thorsten Behrens

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.