Re: [Libreoffice] Moving duplicate code into methods

"Chr. Rossmanith" <ChrRossmanith -AT- gmx.de>
Sat, 07 May 2011 22:54:40 +0200

Hi,

I've used the method names Thorsten suggested, prefixed them with lcl_made them static and end up with two commits for the whole clean up(stage 1 posted on the list, stage 2 improvements). Is that ok forpushing or should I somehow join the two commits into a single one?


Christina



Am 03.05.2011 09:24, schrieb Thorsten Behrens:

Chr. Rossmanith wrote:

I've found two duplicate code with simian and moved it into two new
methods which saves 229 lines of code. It would be nice if someone
could review the patch and at least suggest better names for the
methods...

Context

[Libreoffice] Moving duplicate code into methods · Chr. Rossmanith
- Re: [Libreoffice] Moving duplicate code into methods · Thorsten Behrens
  - Re: [Libreoffice] Moving duplicate code into methods · Chr. Rossmanith
    - Re: [Libreoffice] Moving duplicate code into methods · Jan Holesovsky
  - Re: [Libreoffice] Moving duplicate code into methods · Chr. Rossmanith
    - Re: [Libreoffice] Moving duplicate code into methods · Michael Meeks

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.