Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

in docholder.cxx in DocumentHolder::FreeOffice most of the code is commented out with a remark

// the following code is commented out since for now there is still no completely correct way to detect // whether the office can be terminated, so it is better to have unnecessary process running than
        // to loose any data

If I understand the output of git annotate correctly, these lines are from 2005. Keep or remove (comment & commented code)?

Similar in olecomponent.cxx: OleComponent::getTransferData

// The following optimization does not make much sence currently just because // only one aspect is supported, and only three formats for the aspect are supported // and moreover it is not guarantied that the once returned format will be supported further
        // example - i52106
// TODO/LATER: bring the optimization back when other aspects are supported

From 2005 as well.

Does embeddedobj/test/Container1/BitmapPainter.java belong to a unit test? And is the code of method execute() commented out to prevent the test to fail? What about commented code in <module>/test directories in general? Keep it because it shall be re-enabled some day?

Christina



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.