Re: [Libreoffice] [partial PATCH] Easy hack: expunge duplicate enumerations in vcl

Hi Caolan,

I've continued to remove psp::weight::type. At the end of your last 
e-mail you mention 3 enums. Given that width and weight are already two 
enums there is one left to remove. Or shouldn't "three" be taken literally.

There are still left:

italic, pitch, family <-> FontItalic, FontPitch, FontFamily

For italic I need some help how to translate the vclenum values into the 
fontmanager values.

For the final test, whether it builds or not, I would have to install 
Qt3 in order to allow --enable-kde. Is that the only way? Or could 
someone with Qt3 installed test it for me?

And what about the FW_NORMAL, FW_BLACK etc. from sft.h? Shall they be 
replaced as well?

Christina


 Am 05.04.2011 21:18, schrieb Caolán McNamara:
> On Tue, 2011-04-05 at 21:01 +0200, Christina Roßmanith wrote:
> > removed some methods ToFontWidth() which aren't needed anymore.
> Yup, looks good, the removal of those redundant mappings is the target.
>
> > After that vcl compiles fine for me. But it
> > tells me that KDE is disabled (who did that?), so this part isn't
> > checked by the compiler.
> see --enable-kde/--enable-kde4 as arguments to ./autogen.sh / configure
>
> > If someone could please review this patch. If it is fine I'll go on.
> > Would you recommend a huge push at the end of this work or one for each
> > removed enum?
> Looks good, obviously remove the commented out code. Just the one push
> IMO for the three enums.