Re: [Libreoffice] [PATCH] Improvement of Adding and Removing Color Charts

Hi tml,

I checked manually if the number was in the file. I didn't check 
further, as I don't know a way to do that.

On Fri, 01 Apr 2011 02:00:51 -0600, Tor Lillqvist wrote:
> > I have improved my last patch for the Color Charts.
>
> Thanks! I will commit it, just a question about one thing I don't 
> understand:
>
>  #define RID_SVXPAGE_ASIAN_LAYOUT            (RID_SVX_START + 246)
>  #define RID_OPTPAGE_CHART_DEFCOLORS         (RID_SVX_START + 299)
> +#define RID_OPTQB_COLOR_CHART_DELETE        (RID_SVX_START + 296)
> +#define RID_OPTSTR_COLOR_CHART_DELETE      (RID_SVX_START + 289)
>  #define RID_SVXPAGE_COLORCONFIG             (RID_SVX_START + 249)
>  #define RID_SVXQB_DELETE_COLOR_CONFIG       (RID_SVX_START + 324)
>
> Did you just choose these values manually, checking that they don't
> overlap with any existing one? Or is there some mechanism to do it
> that is guaranteed to get an unused number? Are these assignments
> listen in numerical order somewhere? (But why did you not then add
> your new numbers to that list, too?) Sorry if this is a stupid
> question...
>
> --tml
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

--
--
Met Vriendelijke Groet,
Rob Snelders